Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/odd1086 minor fixes #312

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Fix/odd1086 minor fixes #312

merged 3 commits into from
Jun 30, 2023

Conversation

chuanlin2018
Copy link
Collaborator

This check in solves the problems mentioned in Jira ticket: http://mml.nist.gov:8080/browse/ODD-1086.

Problem #1 seems only happens in edit mode while the two icons are disabled. To test this, set environment.ts to test mode then use this url: http://localhost:4200/lps/test3?editEnabled=true.

Problem #2 happens in both edit and public mode. Edit mode can be tested the same way as problem #1. Public mode can be tested using this url: http://localhost:4200/lps/ECBCC1C1301D2ED9E04306570681B10735.

Problem #3 also happens in both edit and public mode.
To test it in public mode, set environment to non-editing and use url: http://localhost:4200/lps/mds2-2116.
To test it in edit mode, use http://localhost:4200/lps/test0?editEnabled=true. I added test0 to environment.ts for this purpose.

Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues appear to be addressed as seen under oar-docker locally.

@RayPlante RayPlante merged commit 1dbdfea into integration Jun 30, 2023
@RayPlante RayPlante deleted the fix/ODD1086-minor-fixes branch June 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants