Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to metaschema-xslt #393

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

nikitawootten-nist
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist commented Jul 10, 2023

Committer Notes

Prunes content moved to metaschema-xslt.

  • Test suite xslt helpers moved to metaschema-xslt - note the test suite has not been integrated yet.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@nikitawootten-nist
Copy link
Contributor Author

@david-waltermire-nist Currently building the site yields the error:

Error: error building site: POSTCSS: failed to transform "css/hugo-uswds.css" (text/css): env: node: No such file or directory

This also happens in develop (the only difference being a migration to go modules, they are both pointing at the same commit https://github.com/usnistgov/hugo-uswds/tree/cc57ce2e1efa8602d13160e98090bcacc8e6af93)

@david-waltermire
Copy link
Collaborator

@nikitawootten-nist I'll look into the website issue.

We may want to keep the support/xml and support/json directories, which provide base schema support. Otherwise, I like what you are removing.

@nikitawootten-nist
Copy link
Contributor Author

nikitawootten-nist commented Jul 18, 2023

@nikitawootten-nist I'll look into the website issue.

We may want to keep the support/xml and support/json directories, which provide base schema support. Otherwise, I like what you are removing.

@david-waltermire-nist done. @wendellpiez and I were unsure which repo that content should live, but we see an argument for keeping it here.

@david-waltermire david-waltermire mentioned this pull request Jul 19, 2023
8 tasks
@david-waltermire
Copy link
Collaborator

@nikitawootten-nist Would you please rebase to pickup the changes from #398? Thanks.

@david-waltermire david-waltermire linked an issue Jul 29, 2023 that may be closed by this pull request
5 tasks
nikitawootten-nist and others added 3 commits September 1, 2023 09:16
* Removed now irrelevant submodules, dependencies, and scripts
* Switched the docs website to use hugo modules
@david-waltermire
Copy link
Collaborator

@nikitawootten-nist I removed the website build changes and moved these to PR #422. This should clear this PR for merging.

@david-waltermire
Copy link
Collaborator

@nikitawootten-nist Have the Test suite xslt helpers moved to metaschema-xslt? If so, can you check the box above in the PR description?

@david-waltermire
Copy link
Collaborator

@nikitawootten-nist Also, if you believe this is ready, can you remove the [draft] from the title?

@nikitawootten-nist nikitawootten-nist changed the title [DRAFT] Migration to metaschema-xslt Migration to metaschema-xslt Sep 1, 2023
@nikitawootten-nist
Copy link
Contributor Author

@nikitawootten-nist Have the Test suite xslt helpers moved to metaschema-xslt? If so, can you check the box above in the PR description?

Yep, although the test suite helpers have not been wired yet. Otherwise I think we're ready to merge!

@david-waltermire david-waltermire self-requested a review September 1, 2023 17:04
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@david-waltermire david-waltermire merged commit 797591b into usnistgov:develop Sep 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants