Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Values Tutorial #292

Closed
5 tasks done
Tracked by #526
aj-stein-nist opened this issue Jan 11, 2023 · 4 comments · Fixed by #508
Closed
5 tasks done
Tracked by #526

Allowed Values Tutorial #292

aj-stein-nist opened this issue Jan 11, 2023 · 4 comments · Fixed by #508
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@aj-stein-nist
Copy link
Collaborator

aj-stein-nist commented Jan 11, 2023

User Story:

As a Metaschema-enabled tool developer, to know what is required for a Level 1 Capability Metaschema library, I want a tutorial in one to walk through parsing and operating on constraints, primarily focused on the allowed-values enforcement.

Goals:

  • Make tutorials to aid developers of Metaschema-enabled tools to boostrap in their language/runtime/library selection of choice, primarily focused on the allowed-value construct.
  • Demonstrate practical examples.

Dependencies:

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated. Changes to the website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@aj-stein-nist aj-stein-nist added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 11, 2023
@aj-stein-nist
Copy link
Collaborator Author

aj-stein-nist commented Jan 11, 2023

Discuss with the team whether or not Metapath and context operator (.) ala XPath syntax inherited from Metapath) needs a special treatment or can be handled inline in this tutorial re re feedback in usnistgov/metaschema#275.

@aj-stein-nist
Copy link
Collaborator Author

aj-stein-nist commented Jan 11, 2023

@david-waltermire-nist I am sure we can discuss this on Thursday, but in the meantime: did you want to add this to the current sprint? It was brought up in our last Metaschema developer meeting, and I think you said yeah quickly as we ended the call, but I cannot remember. Adding a note now to discuss here or in the triage meeting.

@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Jan 24, 2023
@aj-stein-nist aj-stein-nist mentioned this issue Jan 24, 2023
12 tasks
@aj-stein-nist aj-stein-nist changed the title Allowed Values Tutorial Allowed Values Tutoria Jan 31, 2023
@aj-stein-nist aj-stein-nist changed the title Allowed Values Tutoria Allowed Values Tutorial Feb 2, 2023
@aj-stein-nist
Copy link
Collaborator Author

@Arminta-Jenkins-NIST is helping with the remaining items in #485 for the specification, I intend to get this started tomorrow, the remainder of the week, and then the following week.

aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 11, 2024
@aj-stein-nist aj-stein-nist linked a pull request Jan 11, 2024 that will close this issue
6 tasks
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Jan 16, 2024
Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.
@aj-stein-nist
Copy link
Collaborator Author

So I checked off #411 from deps as the code is merged but the issue is not closed because the code in develop has not merged to main, deployed, and auto-closed the issue.

Per discussion with Dave #508 (comment) and barring no contrasting feedback from the community by COB today, I will leave this issue to be resolved with the closing of #508 and open follow-on issues and work for the related, but separate, tutorials starting next week.

This was referenced Feb 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 6, 2024
* Add allowed-value constraints tutorial for #292

* Intro and required values section for #292

Add introduction and section about how to defined mandatory, required
values for `allowed-values allow-other="no"` for the first segment of
the tutorial.

* Recommended values section and conclusion for #292

Add introduction and section about how to defined mandatory, recommended
values for `allowed-values allow-other="yes"` for the first segment of
the tutorial.

Added a conclusion for wrap-up given the current draft contents.

* Integrate feedback from @david-waltermire:

1. Make second model with allow-other scaffold and include previous
model version with arch change, don't make the model changes logically
separate.
1. Add detail to conclusion paragraph and explicitly defined learning
objectives and that they were met.
1. Not explicit to review but caught when touching up models: make sure
the model version numbers in `<schema-version/>` in the tutorials bump
up with each change to make sense and signify a change. (NOTE: The bumps
are in patch number, not minor number, which is odd open review issue
to check that later).
@david-waltermire david-waltermire added this to the Metaschema 1.0.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants