Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example_1.xml #24

Closed
JDziurlaj opened this issue Aug 3, 2020 · 3 comments · Fixed by #25
Closed

Update example_1.xml #24

JDziurlaj opened this issue Aug 3, 2020 · 3 comments · Fixed by #25
Assignees
Labels

Comments

@JDziurlaj
Copy link
Collaborator

Update example_1.xml to use latest examples found in the CVR Specification

@JDziurlaj JDziurlaj added the bug label Aug 3, 2020
@JDziurlaj JDziurlaj self-assigned this Aug 3, 2020
@moldover
Copy link

moldover commented Aug 5, 2020

@JDziurlaj I also found (I think?) a typo: for the Candidate ObjectId="_C1CN2" / Code / Value is _C1CN3 but it should be _C1CN2 to match the pattern of the other Candidate objects.

@JDziurlaj
Copy link
Collaborator Author

page 75 of the 1500-103 specification references this file, and specific line numbers, so we will be unable to change this example substantially. I've removed the ranks from one of the CVRs as it may be confusing to have a contest change from RCV to non-RCV between CVRs.

@moldover
Copy link

moldover commented Aug 5, 2020

Gotcha. In that case, might be worth leaving those alone (or adding some warning comments) and creating additional correct example files. The examples were super helpful in parsing out the information in NIST 1500-103.

JDziurlaj added a commit that referenced this issue Sep 14, 2020
Update namespaces and version number.  Resolves #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants