Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interact with type checker using module names. #551

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Interact with type checker using module names. #551

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ead4b
Interact with type checker using module names.
toinehartman Dec 24, 2024
9b923ea
Load all required TModels, not only for top modules.
toinehartman Jan 8, 2025
c4b48f7
Merge branch 'main' into fix/rename-refactoring/use-module-names
toinehartman Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rascal-lsp/src/main/rascal/lang/rascal/lsp/refactor/Rename.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,11 @@ private bool rascalContainsName(loc l, str name) {
private set[TModel] rascalTModels(set[loc] fs, PathConfig pcfg) {
RascalCompilerConfig ccfg = rascalCompilerConfig(pcfg)[verbose = false]
[logPathConfig = false];
ms = rascalTModelForLocs(toList(fs), ccfg, dummy_compile1);
list[str] topModuleNames = [getModuleName(mloc, pcfg) | mloc <- fs];
ms = rascalTModelForNames(topModuleNames, ccfg, dummy_compile1);

set[TModel] tmodels = {};
for (modName <- ms.moduleLocs) {
for (str modName <- ms.moduleLocs) {
<found, tm, ms> = getTModelForModule(modName, ms);
if (!found) throw unexpectedFailure("Cannot read TModel for module \'<modName>\'\n<toString(ms.messages)>");
tmodels += convertTModel2PhysicalLocs(tm);
Expand Down
Loading