Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.4.0 #1070

Merged
merged 174 commits into from
Mar 22, 2020
Merged

Release 4.4.0 #1070

merged 174 commits into from
Mar 22, 2020

Conversation

lcharette
Copy link
Member

No description provided.

amosfolz and others added 30 commits June 3, 2019 23:10
@amosfolz
Initial commit
64945e5
@amosfolz
Initial Draft
0554ae0
@amosfolz
Fix filename typos..
8be4d2d
@amosfolz
Begin restructure
8842388
@amosfolz
Malou is not going to like this...
f9f7170
@amosfolz
try to separate out LocaleMissingKeysCommand
5ed640d
@amosfolz
Merge pull request #4 from amosfolz/locale-updates
7e07069 
Try to separate out LocaleMissingKeysCommand
@amosfolz
updates
24e8720
@amosfolz
Reorganize LocaleMissingKeysCommand
423b6d7
@amosfolz
updates
edaaa95
@amosfolz
New draft of LocaleMissingValuesCommand
010902d
@amosfolz
Merge pull request #5 from amosfolz/locale-updates
b3f2226 
Locale updates
@amosfolz
Updates
1446075
@amosfolz
Update LocaleFixKeysCommand.php
0dcf2cc
@amosfolz
Update LocaleFixKeysCommand.php
7b60426
@amosfolz
updates
a910dda
@amosfolz
Finished fix-keys command
286af71
@amosfolz
Looked over all commands. Finalize fix-keys
3ecf85c
@amosfolz
Squashed commit of the following:
f4062d5 
commit 3ecf85c
Author: Amos Folz <[email protected]>
Date:   Wed Jun 12 03:16:44 2019 +0000

    Looked over all commands. Finalize fix-keys

commit 286af71
Author: Amos Folz <[email protected]>
Date:   Tue Jun 11 22:51:57 2019 +0000

    Finished fix-keys command

commit a910dda
Author: Amos Folz <[email protected]>
Date:   Tue Jun 11 03:28:04 2019 +0000

    updates

commit 7b60426
Author: Amos Folz <[email protected]>
Date:   Sun Jun 9 19:32:07 2019 +0000

    Update LocaleFixKeysCommand.php

commit 0dcf2cc
Author: Amos Folz <[email protected]>
Date:   Sun Jun 9 14:18:55 2019 +0000

    Update LocaleFixKeysCommand.php

commit 1446075
Author: Amos Folz <[email protected]>
Date:   Sun Jun 9 12:50:17 2019 +0000

    Updates
@amosfolz
StyleCI Fix
ddef9b8
@amosfolz
Fix error in LocaleMissingKeysCommand
feefb4d
@amosfolz
Fix error in LocaleFixKeysCommand.php
7555311
@amosfolz
Fix broken merge
cee7102
@amosfolz
Retain docblock comments in locale files
628dc7f
@amosfolz
update LocaleFixKeysCommand.php
a1e3272
@amosfolz
Merge branch 'locale-testing' into locale-updates
d687d4f
@amosfolz
Merge pull request #6 from amosfolz/locale-updates
6cd4404 
 Retain docblock comments in locale files
@amosfolz
style CI
166810e
@amosfolz
Merge branch 'locale-updates' of https://github.com/amosfolz/UserFros…
4d0aee2 
…ting into locale-updates
@amosfolz
Merge pull request #7 from amosfolz/locale-updates
4ca900c 
Locale updates
@lcharette lcharette added this to the 4.4.0 milestone Mar 14, 2020
@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #1070 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1070   +/-   ##
=========================================
  Coverage     67.57%   67.57%           
  Complexity     1976     1976           
=========================================
  Files           170      170           
  Lines          6917     6917           
=========================================
  Hits           4674     4674           
  Misses         2243     2243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b25ea...a3b25ea. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 14, 2020 •
edited
Loading

Codecov Report

Merging #1070 into master will increase coverage by 0.78%.
The diff coverage is 86.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1070      +/-   ##
============================================
+ Coverage     66.79%   67.57%   +0.78%     
- Complexity     1933     1976      +43     
============================================
  Files           162      170       +8     
  Lines          6748     6917     +169     
============================================
+ Hits           4507     4674     +167     
- Misses         2241     2243       +2
Impacted Files Coverage Δ Complexity Δ
app/sprinkles/account/src/Account/Registration.php 75.29% <ø> (ø) 23 <0> (ø) ⬇️
...sprinkles/admin/src/Controller/GroupController.php 100% <ø> (ø) 55 <0> (ø) ⬇️
...pp/sprinkles/account/src/Rememberme/PDOStorage.php 94.11% <ø> (ø) 10 <0> (ø) ⬇️
app/sprinkles/core/src/Twig/CacheHelper.php 0% <ø> (ø) 3 <0> (ø) ⬇️
...pp/sprinkles/account/src/Twig/AccountExtension.php 77.77% <ø> (ø) 5 <0> (ø) ⬇️
.../account/src/ServicesProvider/ServicesProvider.php 77.77% <ø> (+0.17%) 11 <0> (-2) ⬇️
app/system/Facade.php 30% <ø> (ø) 27 <0> (ø) ⬇️
.../sprinkles/admin/src/Controller/RoleController.php 100% <ø> (ø) 71 <0> (ø) ⬇️
...les/account/src/Authorize/AuthorizationManager.php 100% <ø> (ø) 20 <0> (ø) ⬇️
...inkles/core/src/Error/Handler/ExceptionHandler.php 34.66% <ø> (ø) 26 <0> (ø) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35dfa8...8eafd4b. Read the comment docs.

Silic0nS0ldier
Silic0nS0ldier approved these changes Mar 14, 2020
View reviewed changes
Copy link
Member

@Silic0nS0ldier Silic0nS0ldier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things of note for upgrade guide, and 1 nit-pick. Apart from that, looking great! And damn, this is a sizable release!

app/sprinkles/account/src/Controller/AccountController.php Show resolved Hide resolved
app/sprinkles/admin/tests/Integration/Controller/GroupControllerTest.php Show resolved Hide resolved
app/sprinkles/core/composer.json Outdated Show resolved Hide resolved
app/sprinkles/core/src/Bakery/DebugCommand.php Outdated Show resolved Hide resolved
@lcharette lcharette merged commit c62790e into master Mar 22, 2020
@lcharette lcharette mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silic0nS0ldier Silic0nS0ldier Silic0nS0ldier approved these changes

Assignees
No one assigned
Labels
Release PR
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcharette @Silic0nS0ldier @amosfolz @ktecho @phillmac