Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to disable markdown shortcuts #4025

Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat: allow to disable markdown shortcuts #4025

merged 3 commits into from
Oct 16, 2024

Conversation

d0zingcat
Copy link
Contributor

Related: #4022

@d0zingcat
Copy link
Contributor Author

d0zingcat commented Oct 16, 2024 •
edited
Loading

Except for issue has discussed about, I have to give a brief illustration about this PR.
Although the best way(to keep code clean and easy to understand) is that we should use "EnableKeymap" like option which defaults to false, if so most users who are used to the keymaps and have upgraded their memos will have to enable this option manually(even though we can issue a release note to notice people about this update).
So I have to use another way, whereas we can give the option to disable this keymap.
BTW, I've added some locales I've been known of but the others I don't have any ideas. Should I use translator to fill them or wait for another PR to update?

boojack
boojack approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise

proto/api/v1/workspace_setting_service.proto Outdated Show resolved Hide resolved
boojack
boojack approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@boojack boojack changed the title Allow to disable markdown keymap feat: allow to disable markdown keymap Oct 16, 2024
@boojack boojack changed the title feat: allow to disable markdown keymap feat: allow to disable markdown shortcuts Oct 16, 2024
@boojack boojack merged commit e5cb203 into usememos:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d0zingcat @boojack