fix: update first day logic for months starting on Sunday #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojack
reviewed
Sep 9, 2024
boojack
changed the title
boojack
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings the start day of the week to Monday causes the memo calendar to display incorrectly
Memos
System calendar
This seems to only be an issue for months where the first day is on a Sunday
Calendar after update, the start day now matches up even when the first day of the month is a Sunday e.g. Sep 2024 and Dec 2024:
Sep 2024
Memos
System calendar
Oct 2024
Memos
System calendar
Nov 2024
Memos
System calendar
Dec 2024
Memos
System calendar
