improve: s3 store custom_domain #3717
Open
+170
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojack
reviewed
Jul 19, 2024
boojack
reviewed
Jul 24, 2024
boojack
reviewed
Jul 25, 2024
boojack
reviewed
Jul 26, 2024
| presignURL, err := s3Client.PresignGetObject(ctx, s3ObjectPayload.Key) | ||
| if err != nil { | ||
| return | ||
| var referenceURL string |
There was a problem hiding this comment.
Could we skip this? This is the scheduler that refreshes the presigned time. For resources that use custom domain, we don't need to refresh its URL.
There was a problem hiding this comment.
I kept this because when I set/unset custom domains, this scheduler will automatically update and switch to using the custom domain URL/presigned URL after the previous signature expires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3575