Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented link previews (frontend files) #3074

Merged
merged 9 commits into from
Mar 16, 2024

Conversation

MehadND
Copy link
Contributor

@MehadND MehadND commented Mar 10, 2024

No description provided.

@MehadND MehadND marked this pull request as ready for review March 10, 2024 21:07
@MehadND MehadND requested a review from boojack as a code owner March 10, 2024 21:07
@MehadND
Copy link
Contributor Author

MehadND commented Mar 10, 2024

Don't know why this Frontend Test / frontend-build (pull_request) check failed?

@MehadND MehadND force-pushed the linkcard-frontend branch 2 times, most recently from 7f014f6 to de1293b Compare March 12, 2024 19:05
@MehadND MehadND marked this pull request as draft March 13, 2024 01:27
@MehadND MehadND marked this pull request as ready for review March 13, 2024 08:58
@MehadND MehadND force-pushed the linkcard-frontend branch 2 times, most recently from e8768d0 to 465b000 Compare March 13, 2024 14:41
@MehadND MehadND requested a review from michaelien March 14, 2024 09:10
@MehadND MehadND force-pushed the linkcard-frontend branch from 869f58b to c851847 Compare March 14, 2024 09:11
@MehadND MehadND requested a review from michaelien March 14, 2024 10:05
web/src/components/MemoContent/Link.tsx Outdated Show resolved Hide resolved
web/src/components/MemoContent/Link.tsx Outdated Show resolved Hide resolved
@MehadND MehadND force-pushed the linkcard-frontend branch from b533726 to 5045378 Compare March 16, 2024 09:31
@MehadND MehadND requested a review from boojack March 16, 2024 14:32
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 9c1e2f8 into usememos:main Mar 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants