Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update i18n for shortcut filter #270

Merged
merged 5 commits into from
Oct 8, 2022
Merged

Conversation

YuJianghao
Copy link
Contributor

Add i18n for resources and shortcuts.

For i18n with constant, I use i18n mark in constants, and render to text with t function in component. Wondering if there's a better solution.

Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack changed the title chore: I18n chore: update i18n for shortcut filter Oct 8, 2022
@boojack boojack merged commit 4ada7dc into usememos:main Oct 8, 2022
@YuJianghao YuJianghao deleted the i18n branch October 20, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants