Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Fix the initial loading of the metrics + event preview page" & "Fix 3 files that have type errors" #391

Merged
merged 7 commits into from
Dec 19, 2022

Conversation

glamboyosa
Copy link
Contributor

Closes

Closes LOT-421 & LOT-420

Testing Plan

LOT-421

  • Log into the app.
  • Go to metrics.
  • The two spinners should not be together but in their own container, centered.

LOT-420

N/A

@linear
Copy link

linear bot commented Dec 19, 2022

LOT-421 Fix the initial loading of the metrics + event preview page

When first loading (refresh) on the metrics page, the event preview and metrics both have loading symbols very close to each other instead of where their containers are supposed to be on the screen.

LOT-420 Fix 3 files that have type errors

@glamboyosa glamboyosa temporarily deployed to Development December 19, 2022 14:02 — with GitHub Actions Inactive
@glamboyosa glamboyosa temporarily deployed to Development December 19, 2022 14:24 — with GitHub Actions Inactive
@glamboyosa glamboyosa temporarily deployed to Development December 19, 2022 14:35 — with GitHub Actions Inactive
@glamboyosa glamboyosa requested a review from mnida December 19, 2022 14:46
@glamboyosa glamboyosa temporarily deployed to Development December 19, 2022 14:56 — with GitHub Actions Inactive
@mnida mnida temporarily deployed to Development December 19, 2022 17:39 — with GitHub Actions Inactive
This reverts commit 19af5d8.
@mnida mnida temporarily deployed to Development December 19, 2022 18:48 — with GitHub Actions Inactive
@mnida mnida merged commit 774c114 into main Dec 19, 2022
@diego-escobedo diego-escobedo deleted the 420-421-bug-fixes branch January 4, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants