Feature/605716129 update front end connector #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/wouteraj patch 1
…ild-package Feature/600707036 gh actions build package
* feat: filters in services, move mock services & holder cache service * feat: added exchange cache and transformer service * feat: created dgt category cache service * style: fix tslint errors * feat: created connection cache service * feat: created invite cache service * feat: transformers for SDMs * fix: added transformers * feat: created source cache service * feat: created purpose cache service * feat: purpose- and connectionTransformer * fix: moved configuration base models to same folder * feat: source transformer WIP * feat: moved clientconfiguration to shared * feat: finished uri cache service implementation * feat: implemented uri factpry services * fix: make uriservice use ldresource not dgtldtriple * fix: added uri services to public api * fix: fixed broken import & build errors * fix: added public api exports for cache services * feat: conncetion transformer + remove category transformer * fix: removed unnecessary observable * fix: use uri service in cache services * fix: imports and build errors * fix: made generate parameters clearer * feat: source transformer added solid config support * fix: implemented get and query functions * feat: source transformer almost done * fix: fixed cache constructor error * Revert "fix: fixed cache constructor error" This reverts commit 12aa352. * feat: implemented delete function * fix: fixed build errors * fix: added root triple when transforming system data models * fix: removed duplicate exchange triple in some transformers * fix: Preparing solid sources works again * fix: Define mssql config commands as strings * feat: Set resource uris through a factory * fix: generic methods in connection services * fix: don't use closed pools in mssql connector * fix: Decode uri's when necessary * feat: added representation factories * fix: removed unnecessary logic from sparql query service * Moved credential and policy to shared * fix: various fixes * Fix: made compatible with representation factories * feat: implemented deserialization * fix: exchanges bug * fix: removed console.log * added category transformer and cache service * fix: changed forkJoin to concat in save of cache-solid-service * feat: user data supported in cache * fix: removed triples from sdm * fix: injectable replaced with dgtinjectable * fix: fixing solid cache regressions * fix: improved delete in solid cache service * fix: aligned connection service impl with source service * fix: set filter in category transformer * chore: version bump Co-authored-by: Stijn Taelemans <[email protected]> Co-authored-by: Arthur Joppart <[email protected]> Co-authored-by: Arne Vandoorslaer <[email protected]>
* feat: added remote save * feat: added security service * chore: version bump
…on-with-platform Feature/608779373 fix integration with platform
* error handling and tweaks * feat: start of typereg in save * fix: connection bug in mssql connector * feat: remove prefix now supports numbers * cleaned some logs to make console readable again * feat: typeregistrations in upstreamSync should work * still add / update bug * still circular dependecy * fix: Removed circular dependency in solid connector * fix: tried to get profile for MSSQL connections * fix: upstreamsyn can almost save WIP * fix: another bugfix * feat: filters in services, move mock services & holder cache service * feat: added exchange cache and transformer service * feat: created dgt category cache service * style: fix tslint errors * feat: created connection cache service * feat: created invite cache service * feat: transformers for SDMs * fix: added transformers * feat: created source cache service * feat: created purpose cache service * feat: purpose- and connectionTransformer * fix: moved configuration base models to same folder * feat: source transformer WIP * feat: moved clientconfiguration to shared * feat: finished uri cache service implementation * feat: implemented uri factpry services * fix: make uriservice use ldresource not dgtldtriple * fix: added uri services to public api * fix: fixed broken import & build errors * fix: added public api exports for cache services * feat: conncetion transformer + remove category transformer * fix: removed unnecessary observable * fix: use uri service in cache services * fix: imports and build errors * fix: made generate parameters clearer * feat: source transformer added solid config support * fix: implemented get and query functions * feat: source transformer almost done * fix: fixed cache constructor error * Revert "fix: fixed cache constructor error" This reverts commit 12aa352. * feat: implemented delete function * fix: fixed build errors * fix: added root triple when transforming system data models * fix: removed duplicate exchange triple in some transformers * fix: Preparing solid sources works again * fix: Define mssql config commands as strings * feat: Set resource uris through a factory * fix: generic methods in connection services * fix: don't use closed pools in mssql connector * fix: Decode uri's when necessary * feat: added representation factories * fix: removed unnecessary logic from sparql query service * Moved credential and policy to shared * fix: various fixes * Fix: made compatible with representation factories * feat: added support for upstream sync to solid * feat: implemented deserialization * fix: exchanges bug * fix: removed console.log * added category transformer and cache service * fix: changed forkJoin to concat in save of cache-solid-service * feat: user data supported in cache * fix: removed triples from sdm * fix: injectable replaced with dgtinjectable * fix: fixing solid cache regressions * feat: upstreamsync with type registrations * fix: removed console log * fix: cleaned workflow service * fix: fixed sql connector connection pool * fix: filter exchanges based on graph * fix: avoid null in turtle factory * fix: jasmine type errors when running tests * fix: fixed circular dependency * fix: fixed automated testing * refactor: moved type registrations to connectors * style: added prettier config * feat: added minimum level for logging data * refactor: split solid connector in solid service * fix: query resources by filter * fix: add solid profile to type registrations when discovering * fix: execute workflows when querying data * refactor: split off cache refresh logic * feat: check if cache is stale for exchange before refresh * refactor: added logging to sparql comunica service * fix: don't use filter when executing workflow * style: fix linting issues * chore: minor version bump * fix: fixed incorrect imports * fix: fixed circular dependency * test: fixed broken tests Co-authored-by: Wouter Janssens <[email protected]> Co-authored-by: Stijn Taelemans <[email protected]> Co-authored-by: Arne Vandoorslaer <[email protected]>
… when querying * feat: first attempt * feat: filter according to purposes * fix: moved logic to LDUtils * test: tests for LDUtils * fix: wrong imports * fix: duplicate resources when querying * chore: minor version bump * style: fix linting errors Co-authored-by: Wouter Janssens <[email protected]>
* fix: instantiate workflowactions * chore: minor version bump * test: fixed crypto service test Co-authored-by: Arne Vandoorslaer <[email protected]>
* feat: first attempt * feat: filter according to purposes * feat: delete exchange now deletes data of that exchange * fix: moved logic to LDUtils * test: tests for LDUtils * fix: tslint * fix: wrong imports * feat: delete connections * feat: added getConnectionsForHolder to connection service * fix: delete connection without exchanges * feat: begin of modifying all transformers * feat: holder, category and policy transformers * feat: adapted source transformer + minor other changes * feat: purpose and workflow transformer * feat: connectortype transformer * feat: connection transformer * feat: changed delete implementation * chore: minor version bump * build: merged ci and test workflows Co-authored-by: Wouter Janssens <[email protected]>
* feat: removed refreshForExchanges from query * chore: minor version bump Co-authored-by: Wouter Janssens <[email protected]>
* refactor: renamed DGTDataValue to DGTLDResource * refactor: changed values to DGTLDResource[] * refactor: changed DGTDataValue to DGTLDResource * refactor: changed DGTDataValue to DGTLDResource * refactor: rename data values to resources * refactor: changing datavalue to resource * fix: getting correct profile and resources * feat: added updateValues * feat: updated tests * feat: renamed data-value.component to data-resource.component * feat: generate uri based on type registrations * feat: added connection to generate * fix: don't load exchanges when generating solid uri * fix: only try to add or update resources if any are given * fix: only generate a new uri for cache when necesary * style: fixed linting issues * chore: minor version bump Co-authored-by: Wouter Janssens <[email protected]>
…update-front-end-connector
* feat: implemented invite remote service * feat: added extra fields to DGTInvite * feat: added getInvitesForHolder functionality * feat: adapted invite transformer * fix: fixed invite transformer * feat: add getPlatformPublicUrl() to invite service * fix: change public url config name * refactor: use query invite instead of getInvitesForHolder * chore: minor version bump * style: fix linting issues Co-authored-by: Wouter Janssens <[email protected]>
* feat: added services for data groups * style: fixed linting issues * test: fix broken tests * chore: version bump * fix: fixed broken import Co-authored-by: Wouter Janssens <[email protected]>
* feat: allow holders to be merged * refactor: removed logs from transformers * refactor: removed unnecessary info logs * fix: send uris instead of resources when merging holders * chore: version bump
* feat: refresh cache for holder or source * chore: version bump
* fix: show emails * chore: version bump Co-authored-by: Arthur Joppart <[email protected]>
* fix: workflow destination save * refactor: removed unused code * fix: yarn -> npm * fix: reverted link changes * fix: write to workflow destination * chore: version bump Co-authored-by: Wouter Janssens <[email protected]>
wouteraj
requested changes
Feb 9, 2021
Comment on lines
35
to
39
| this.connections.save([{ ...connection, state: DGTConnectionState.CONNECTING, configuration: { ...connection.configuration, sessionInfo: session.info } }]); | ||
|
|
||
| if (!session.info.isLoggedIn) { | ||
| session.login({ oidcIssuer: source.configuration.issuer, redirectUrl: source.configuration.callbackUri }); | ||
| } |
There was a problem hiding this comment.
The connection is not saved by the time the user is redirected.
wouteraj
requested changes
Feb 9, 2021
Comment on lines
+6
to
+12
| public abstract delete<T>(uri: string, headers?: { [key: string]: string }, session?: Session): Observable<DGTHttpResponse<T>>; | ||
| public abstract get<T>(uri: string, headers?: { [key: string]: string }, isText?: boolean, session?: Session): Observable<DGTHttpResponse<T>>; | ||
| public abstract patch<T>(uri: string, body: any, headers?: { [key: string]: string }, session?: Session): Observable<DGTHttpResponse<T>>; | ||
| public abstract post<T>(uri: string, body: any, headers?: { [key: string]: string }, session?: Session): Observable<DGTHttpResponse<T>>; | ||
| public abstract put<T>(uri: string, body: any, headers?: { [key: string]: string }, session?: Session): Observable<DGTHttpResponse<T>>; | ||
| public abstract head<T>(uri: string, headers?: { [key: string]: string }, session?: Session): Observable<DGTHttpResponse<T>>; | ||
| public abstract options<T>(uri: string, headers?: { [key: string]: string }, session?: Session): Observable<DGTHttpResponse<T>>; |
There was a problem hiding this comment.
Adding Inrupt's Session attribute breaks the loose coupling between the different implementations. This should never be done.
| throw new DGTErrorArgument('Argument connection should be set.', connection); | ||
| } | ||
|
|
||
| const session = new Session(); |
There was a problem hiding this comment.
Have you checked the constructor argument? It seems like you can pass a storage object to a new session.
constructor(sessionOptions?: Partial<ISessionOptions>, sessionId?: string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.