-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use logger pattern for translator #145
feat: use logger pattern for translator #145
Conversation
Not sure why that test fails, I've tried removing the mocked fetch in tests/setup.ts, but error stays. Seems componentsjs is suddenly looking for npm modules when it shouldn't |
@lem-onade For some reason test coverage dropped in the dgt-components package. |
because there's 1 failing test in dgt-components |
A thought: creating a new or should I not have copied the |
Yes, an (additional) factory that already keeps the files is a good option. Maybe the translator need to be adapted then to take an optional translation file as dependency |
Will implement this, also do you that |
Labels probably not, since nothing is printed (though it would not hurt to leave them in). Still, a |
I refactored getTranslatorFor to return a translator for a specific language, rather than a label, wdyt? |
Removed old translators (one in dgt-utils and one in dgt-components)
Created new translator with factory