-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tpv on production to version 2.2.0 #1158
Conversation
30769ce
to
f86b425
Compare
1db47bc
to
aea121a
Compare
2cf0278
to
fad9849
Compare
…o that highest non-value spec is default and everything else is small_input_rule, medium_input_rule, fail_rule
fad9849
to
c5dbf02
Compare
Tool specifications in tools.yml have previously had lowest cores/mem as default and higher resource allocations set in conditional rules. This changes to have the non-failing condition with the highest cores/mem as default and lower resource allocations set in conditional rules, e.g. deeptools_plot_heatmap
changes to
Using this convention should make it easier to switch to using a shared database rule for a tool. If we wanted to use shared_db for deeptools_plot_heatmap we could either delete the entry entirely or delete {cores: 7, mem: 26.9} from the above and keep using the small input rule. |
This PR doesn't change the rank function in any way but I do think it needs to change. I'm working on alternatives to the rank function on dev. We can swap the rank function later on when we have seen what the new edge cases will be on production. |
) | ||
|
||
tag_values_match(entity, include_tags, exclude_tags) | ||
# helpers.tag_values_match(entity, include_tags, exclude_tags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make a release of tpv immediately so you can use this instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be good!
Co-authored-by: Nuwan Goonasekera <[email protected]>
Co-authored-by: Nuwan Goonasekera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update tpv on production to 2.1.0.
Job destinations are defined in tpv
destinations.yml.j2
instead of job conf.Job conf limits are now in aarnet.usegalaxy.org.au and templated into the job conf.
Pull request linting has updated to check templating of files as well as
tpv lint
.TPV shared rules for tools will be used in addition to Galaxy Australia's tool rules. GA's rules take precedence.
GA tool rules now always have mem values and rule IDs.
This PR also removes some legacy dtd code.
I'm changing this from 'draft' to 'ready for review' but it can't be merged without first disabling the automatic copying of tpv files to production. I'd like to merge this early in the day when there is a lower rate of job submission.