Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX needflow graphviz links #1339

Merged
merged 13 commits into from
Oct 28, 2024
Merged

🐛 FIX needflow graphviz links #1339

merged 13 commits into from
Oct 28, 2024

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 28, 2024

Links are now initially calculated relative to the containing document.

For PNGs, the links are defined as https://developer.mozilla.org/en-US/docs/Web/HTML/Element/map in the document, so this is correct.

For SVGs, the graphs are extracted to external files, and in this case the links are modified by sphinx to be relative to the SVG file
(from sphinx 7.2 onwards, see: sphinx-doc/sphinx#11078)

@chrisjsewell chrisjsewell linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.98%. Comparing base (4e10030) to head (25af27c).
Report is 81 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/directives/needflow/_graphviz.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1339      +/-   ##
==========================================
+ Coverage   86.87%   87.98%   +1.10%     
==========================================
  Files          56       60       +4     
  Lines        6532     7100     +568     
==========================================
+ Hits         5675     6247     +572     
+ Misses        857      853       -4     
Flag Coverage Δ
pytests 87.98% <68.75%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell marked this pull request as ready for review October 28, 2024 15:31
@chrisjsewell chrisjsewell requested a review from danwos October 28, 2024 15:32
@chrisjsewell chrisjsewell merged commit 8aa192b into master Oct 28, 2024
16 of 17 checks passed
@chrisjsewell chrisjsewell deleted the fix-graphviz-links branch October 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphviz needflow links are broken
2 participants