Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add needs_from_toml configuration #1337

Merged
merged 10 commits into from
Oct 27, 2024
Merged

✨ Add needs_from_toml configuration #1337

merged 10 commits into from
Oct 27, 2024

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 25, 2024

This configuration allows for a path to a toml file to be specified.
In this case, needs configuration will be read from it and merged into the config from the conf.py.
An additional needs_from_toml_table config controls the toml table to read from.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (4e10030) to head (96f12ff).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/needs.py 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
+ Coverage   86.87%   88.00%   +1.12%     
==========================================
  Files          56       60       +4     
  Lines        6532     7070     +538     
==========================================
+ Hits         5675     6222     +547     
+ Misses        857      848       -9     
Flag Coverage Δ
pytests 88.00% <83.33%> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sphinx_needs/config.py Outdated Show resolved Hide resolved
sphinx_needs/needs.py Show resolved Hide resolved
@chrisjsewell chrisjsewell marked this pull request as ready for review October 25, 2024 22:32
@chrisjsewell chrisjsewell requested a review from ubmarco October 25, 2024 22:34
Copy link
Member

@ubmarco ubmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording questions

docs/configuration.rst Outdated Show resolved Hide resolved
sphinx_needs/config.py Outdated Show resolved Hide resolved
sphinx_needs/needs.py Show resolved Hide resolved
@chrisjsewell chrisjsewell requested a review from ubmarco October 27, 2024 12:38
@chrisjsewell chrisjsewell merged commit 43a43b8 into master Oct 27, 2024
18 checks passed
@chrisjsewell chrisjsewell deleted the config-from-toml branch October 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants