Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor cleanup logic to expose buildkitd.log #73

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Dec 17, 2024

Previosuly, we only killed the buildkitd process and unmounted if builderInfo was non null. This was wrong cause we could have setup builkdkitd, but failed after that step. This would then rely on the last ditch effort by the post action to cleanup. We now change the proc kill and unmount to happen on any build error.


Important

Refactor cleanup logic in main.ts to ensure buildkitd is killed and unmounted on any build error, and increase buildkitd socket timeout in setup_builder.ts.

  • Behavior:
    • Refactor cleanup logic in main.ts to kill buildkitd and unmount on any build error, not just when builderInfo is non-null.
    • Expose buildkitd.log contents on build error in main.ts.
  • Timeout:
    • Increase buildkitd socket timeout from 5 to 10 seconds in setup_builder.ts.

This description was created by Ellipsis for 54bc4e0. It will automatically update as commits are pushed.

Previosuly, we only killed the buildkitd process and unmounted
if builderInfo was non null. This was wrong cause we could have setup
builkdkitd, but failed after that step. This would then rely on the last
ditch effort by the post action to cleanup. We now change the proc kill
and unmount to happen on any build error.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 54bc4e0 in 31 seconds

More details
  • Looked at 111 lines of code in 2 files
  • Skipped 2 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_9Fy97SQ3ozypIVP1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit 7227817 into master Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant