src: refactor cleanup logic to expose buildkitd.log #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previosuly, we only killed the buildkitd process and unmounted if builderInfo was non null. This was wrong cause we could have setup builkdkitd, but failed after that step. This would then rely on the last ditch effort by the post action to cleanup. We now change the proc kill and unmount to happen on any build error.
Important
Refactor cleanup logic in
main.ts
to ensurebuildkitd
is killed and unmounted on any build error, and increasebuildkitd
socket timeout insetup_builder.ts
.main.ts
to killbuildkitd
and unmount on any build error, not just whenbuilderInfo
is non-null.buildkitd.log
contents on build error inmain.ts
.buildkitd
socket timeout from 5 to 10 seconds insetup_builder.ts
.This description was created by for 54bc4e0. It will automatically update as commits are pushed.