Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: ignore error when theres nothing mounted #70

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Dec 13, 2024

Important

Improve error handling in src/main.ts to ignore warnings when no mounts are found during cleanup.

  • Error Handling:
    • In src/main.ts, modify error handling during cleanup to ignore errors from grep when no mounts are found (exit code 1).
    • This prevents unnecessary warnings in logs when no mounts are present.

This description was created by Ellipsis for 1df1b3c. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1df1b3c in 25 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main.ts:401
  • Draft comment:
    The error handling logic assumes that any error message containing 'exit code 1' is due to grep finding no mounts. This might not always be the case and could lead to ignoring other potential errors. Consider checking the specific error type or message more precisely.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_txkXjplSnXUoESlS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit 23eae44 into master Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants