Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add xero sync #56

Merged
merged 9 commits into from
Apr 2, 2024
Merged

feat: add xero sync #56

merged 9 commits into from
Apr 2, 2024

Conversation

jatinsandilya
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
venice ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 0:41am

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Apr 1, 2024

PR Summary

  • Adding Support for Xero Connector
    The development team has integrated a new connector named "Xero". This is achieved by adjusting import statements in several files such as connectors.def.ts, connectors.merged.ts, and connectors.server.ts to include connectorXero from the respective directories.

  • Establishing Xero Connector Structure
    For the Xero connector to work, new files were added inside the connector-xero directory for better organization and function. These files include server.ts, def.ts, index.ts and package.json.

  • Integration of Xero connector in Application Config and CLI
    The necessary configuration has been made in app-config and cli applications to support the newly added Xero connector. Changes were made in the package.json for both applications.

  • Adding Xero Logo
    The Xero logo has been added to the web/public/_assets directory for branding purposes.

  • Updating Dependency Lock File
    Lastly, the pnpm-lock.yaml file was updated to include the newly needed dependencies and links for the successful operation of the connector-xero package.

@jatinsandilya jatinsandilya force-pushed the feat/add-xero-connector branch from 7e3fe23 to 4f700f7 Compare April 1, 2024 18:55
@jatinsandilya jatinsandilya requested a review from tonyxiao April 1, 2024 19:35
@tonyxiao tonyxiao marked this pull request as ready for review April 2, 2024 00:44
@tonyxiao tonyxiao merged commit 6e94d3a into main Apr 2, 2024
6 checks passed
@tonyxiao tonyxiao deleted the feat/add-xero-connector branch April 2, 2024 00:44
jatinsandilya
jatinsandilya commented Apr 2, 2024
View reviewed changes
connectors/connector-xero/server.ts Outdated
newInstance: ({settings, fetchLinks}) => {
const xero = initXeroSDK({
headers: {
authorization: `Bearer ${settings.oauth.credentials.access_token}`,
},
links: (defaultLinks) => [
(req, next) => {
if (xero.clientOptions.baseUrl) {
req.headers.set(
nangoProxyLink.kBaseUrlOverride,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept getting 401s and 403 when I used it like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyxiao tonyxiao tonyxiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatinsandilya @tonyxiao