Skip to content

Commit

Permalink
Migrate from yarn to pnpm and make other DX improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
yenbekbay committed Sep 2, 2022
1 parent 0c21567 commit 156a073
Show file tree
Hide file tree
Showing 62 changed files with 12,974 additions and 204,431 deletions.
14 changes: 9 additions & 5 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
# Unignore dotfiles
!.*

# Node.js
# dependencies
**/node_modules/

# Generated files
# temporary files
**/temp/

# generated files
**/__generated__/

# Jest snapshot files
# jest
*.snap

# App builds
/apps/next/.next
# next.js
/apps/next/.next/
/apps/next/out/

# vim: set filetype=ignore:
27 changes: 16 additions & 11 deletions .github/workflows/validate-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,35 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Checkout repo
uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3

- name: Set up Node
uses: actions/setup-node@v2
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: '16.10.0'
cache: yarn
cache-dependency-path: '**/yarn.lock'
node-version: 16

- uses: pnpm/[email protected]
name: Install pnpm
id: pnpm-install
with:
version: 7
run_install: false

# - name: Set up tmate session
# uses: mxschmitt/action-tmate@v2

- name: Install dependencies
run: yarn install --frozen-lockfile --check-files
run: pnpm install --frozen-lockfile

- name: Run type checks
run: npm run typecheck
run: pnpm run typecheck

- name: Run lint
run: npm run lint
run: pnpm run lint

- name: Run tests
run: npm run test::ci
run: pnpm run test::ci

- name: Send Slack notification for job status
uses: 8398a7/action-slack@v3
Expand Down
15 changes: 6 additions & 9 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,16 @@ yarn-error.log*
# local env files
.env*.local
.env
.envrc

# symlinked for working with ledgerSyncFS
/data

# eslint
/.eslintcache
# vercel
.vercel

# typescript
/tsconfig.tsbuildinfo
*.tsbuildinfo

# git-crypt
*.git-crypt-key
# https://vercel.com/alka/ledger-sync
.vercel

*.envrc
# eslint
.eslintcache
1 change: 0 additions & 1 deletion .husky/.gitignore

This file was deleted.

5 changes: 4 additions & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
./node_modules/.bin/lint-staged --config config/lint-staged.config.js
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npx lint-staged
11 changes: 11 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
public-hoist-pattern[]=@jest/types
public-hoist-pattern[]=@trpc/server
public-hoist-pattern[]=cac
public-hoist-pattern[]=chrono-node
public-hoist-pattern[]=firebase
public-hoist-pattern[]=js-combinatorics
public-hoist-pattern[]=micro-memoize
public-hoist-pattern[]=plaid
public-hoist-pattern[]=remeda
public-hoist-pattern[]=timm
public-hoist-pattern[]=zod
16 changes: 10 additions & 6 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
# Node.js
# dependencies
**/node_modules/

# Temporary files
# temporary files
**/temp/

# Generated files
# generated files
**/__generated__/

# Jest snapshot files
# jest
*.snap

# App builds
/apps/next/.next
# next.js
/apps/next/.next/
/apps/next/out/

# pnpm
pnpm-lock.yaml

# vim: set filetype=ignore:
2 changes: 0 additions & 2 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@
"esbenp.prettier-vscode",
"fabiospampinato.vscode-highlight",
"forbeslindesay.vscode-sql-template-literal",
"graphql.vscode-graphql",
"maptz.regionfolder",
"mikestead.dotenv",
"msjsdiag.debugger-for-chrome",
"naumovs.color-highlight",
"orta.vscode-jest",
"sastan.twind-intellisense",
"spywhere.mark-jump",
"toba.vsfire",
"usernamehw.errorlens"
]
}
41 changes: 18 additions & 23 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,28 @@
"[beancount]": {
"editor.defaultFormatter": "dongfg.vscode-beancount-formatter"
},
"[dockerfile]": {
"editor.defaultFormatter": null
},
"[dotenv]": {
"editor.defaultFormatter": null
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[ignore]": {
"editor.defaultFormatter": null
"[javascriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[markdown]": {
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[tailwindcss]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[typescriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[yaml]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[shellscript]": {
Expand All @@ -24,7 +33,6 @@
"editor.defaultFormatter": "adpyke.vscode-sql-formatter"
},
"css.validate": false,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.insertSpaces": true,
"editor.quickSuggestions": {
"strings": true
Expand Down Expand Up @@ -60,21 +68,8 @@
}
]
},
"javascript.format.enable": false,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
"javascript.preferences.quoteStyle": "single",
"javascript.preferences.useAliasesForRenames": true,
"javascript.suggestionActions.enabled": false,
"json.format.enable": false,
"js/ts.implicitProjectConfig.checkJs": true,
"markJump.strictLimit": "disable",
"search.exclude": {
"/.yarn/": true
},
"typescript.disableAutomaticTypeAcquisition": true,
"typescript.format.enable": false,
"typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
"typescript.preferences.quoteStyle": "single",
"typescript.preferences.useAliasesForRenames": true,
"typescript.tsc.autoDetect": "off",
"typescript.tsdk": "./node_modules/typescript/lib"
}
Loading

0 comments on commit 156a073

Please sign in to comment.