-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new scale-info and codec releases #663
Conversation
@@ -152,7 +152,7 @@ where | |||
} | |||
|
|||
#[inline] | |||
fn encode_to<O: scale::Output>(&self, output: &mut O) { | |||
fn encode_to<O: scale::Output + ?Sized>(&self, output: &mut O) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition!
form::CompactForm, | ||
IntoCompact as _, | ||
form::{ | ||
FormString, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a FormString
bringing to the table?
All in all the PR LGTM, however I really wonder about some more recent design changes in the |
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
===========================================
- Coverage 82.89% 67.05% -15.84%
===========================================
Files 161 161
Lines 7389 7389
===========================================
- Hits 6125 4955 -1170
- Misses 1264 2434 +1170
Continue to review full report at Codecov.
|
See original rationale: paritytech/scale-info#35 (comment) It's because substrate runtimes discourage use of One idea I still need to investigate is the possibility of not storing the metadata in the runtime itself, but doing something similar to |
Related use-ink/cargo-contract#164