Add E2E testing framework MVP #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has been exported via cargo install subxt-cli subxt metadata > contracts-node.scale For `substrate-contracts-node` v0.19.0.
We run into error[E0514]: found crate `core` compiled by an incompatible version of rustc otherwise, due to the e2e tests that build the contract in stable.
This reverts commit a99319c.
Otherwise our CI will run into `compiled by an incompatible version of rustc`, since we use nightly for `clippy`, but `stable` for `cargo-contract. The CI uses a `CARGO_TARGET_DIR` env variable which causes these collisions.
This reverts commit a942795.
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
===========================================
- Coverage 71.48% 45.05% -26.44%
===========================================
Files 187 195 +8
Lines 5857 5968 +111
===========================================
- Hits 4187 2689 -1498
- Misses 1670 3279 +1609
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Closing in favor of creating a new, cleaned up, PR for easier reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP for #1234.
Contains only E2E tests for our
contract-transferexample so far. Once we've nailed down the API I'll add E2E tests for the other examples in follow-up PRs. The best way to look at this PR is, I think, to look at the#[ink::e2e_test]tests for that example.I've annotated a couple of
TODO(#xxx)comments ‒ I'll create the issues + add the number before merging, I'm just waiting for approvals beforehand.