-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust specific build info to metadata #680
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8fd0b84
Write (slightly-hardcoded) build info to metadata
HCastano 92ad530
Add `channel-date` formatted rustc version to metadata
HCastano 42e22c4
Remove `features` from `BuildInfo`
HCastano beac37e
Add `wasm-opt` version to metadata
HCastano f6c3fa2
Move `BuildInfo` construction to `build` closure
HCastano ad19ec9
Add `build_info` field to tests
HCastano a12564c
Improve conversion between `BuildInfo` and `serde_json::Map`
HCastano b7a3d18
Merge branch 'master' into hc-add-build-info
HCastano 6a2a1b3
Add `version` getter to `WasmOptHandler`
HCastano 8d5f92d
Move code which indicates current toolchain to `utils`
HCastano 5a2ad6a
Handle case where `cargo-contract` version can't be parsed
HCastano 415ec3d
Merge branch 'master' into hc-add-build-info
HCastano 7ec78dd
Use a stable `rustc` version
HCastano 5c65ff9
Merge branch 'master' into hc-add-build-info
HCastano 46ea782
Add `keep_debug_symbols` to metadata
HCastano 276a7a4
Add `CHANGELOG` entry
HCastano 8a6630c
Merge branch 'master' into hc-add-build-info
HCastano 83aed6d
Remove `version` from `WasmOptSettings`
HCastano bae9094
Add target triple to `build_info`
HCastano 00e8213
Move `CARGO_PKG_VERSION` into a const
HCastano a75b726
Appease Clippy
HCastano 6eea64c
Rename field to more accurate `rust_toolchain`
HCastano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we convert to loosely typed json
Map
here? Is that for alt. compilers e.g.solang
to provide arbitrary data here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, other compilers may want to include other info here. It's also useful for us if we decide that we need to add/remove info later on