Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run sgeop #189

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Run sgeop #189

merged 4 commits into from
Oct 23, 2024

Conversation

anastassiavybornova
Copy link
Collaborator

resolves #183

@anastassiavybornova anastassiavybornova self-assigned this Oct 23, 2024
jGaboardi
jGaboardi reviewed Oct 23, 2024
View reviewed changes
notebooks/evaluation/evaluate_h3cells.ipynb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parenx differences are wild. Is that maybe due to the input data for parenx still having the service roads?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think so. we have an open issue about re-running parenx #130 so i hope this will be fixed by that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and the evaluation notebook is still under construction, for now i only updated some variable names but have not changed much about the underlying analysis, separate PR will follow for that)

Copy link
Collaborator

@jGaboardi jGaboardi Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we handle #130 prior this PR? Or simply rerun this notebook again in another PR after that PR?

I started typing this before reading your message above.

@martinfleis martinfleis merged commit 9183c53 into main Oct 23, 2024
2 checks passed
@martinfleis martinfleis deleted the run-sgeop branch October 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@jGaboardi jGaboardi jGaboardi approved these changes

Assignees

@anastassiavybornova anastassiavybornova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate sgeop data
3 participants
@anastassiavybornova @jGaboardi @martinfleis