Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase tolerance for testing #72

Closed
jGaboardi opened this issue Nov 3, 2024 · 2 comments
Closed

increase tolerance for testing #72

jGaboardi opened this issue Nov 3, 2024 · 2 comments
Assignees
@jGaboardi
Labels
tests/CI

Comments

@jGaboardi
Copy link
Collaborator

Since we are erroring out in the last test from test_simplify_network_full_fua(), we can be virtually certain that small changes in precision are the cause of the failures in dev starting several days ago.

I try increasing the tolerance incrementally by +0.1 to see where that gets us.
@jGaboardi jGaboardi self-assigned this Nov 3, 2024
@jGaboardi
Copy link
Collaborator Author

jGaboardi commented Nov 4, 2024 •
edited
Loading

Seems to not be a tolerance thing, but a reversed coordinates things... #73 (comment)

#74 (comment)

This was referenced Nov 5, 2024
Closed
Merged
@jGaboardi
Copy link
Collaborator Author

resolved by #73

@jGaboardi jGaboardi mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
tests/CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jGaboardi