Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for exclusion mask #104

Merged
merged 8 commits into from
Nov 24, 2024
Merged

test for exclusion mask #104

merged 8 commits into from
Nov 24, 2024

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented Nov 23, 2024

@jGaboardi jGaboardi self-assigned this Nov 23, 2024
@jGaboardi
Copy link
Collaborator Author

So these new "edge cases" are not only edge cases in terms of coordinate order, wild precision, etc. --> The actual index order in the resultant dataframes are different. I have confirmed that the returned geometries are equivalent (within tolerance) across OSs, both visually and programmatically – but in different orders.

@jGaboardi
Copy link
Collaborator Author

macOS (ARM) vs. Ubuntu -- complete

simplified_exclusion_mask_comparison_complete

@jGaboardi
Copy link
Collaborator Author

macOS (ARM) vs. Ubuntu -- "bad" subset

simplified_exclusion_mask_comparison_bad_subset

@jGaboardi
Copy link
Collaborator Author

Index sort

simplified_exclusion_mask_comparison_bad_subset_index_sort

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.8%. Comparing base (b2a1e53) to head (7f08d65).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #104     +/-   ##
=======================================
+ Coverage   98.6%   98.8%   +0.2%     
=======================================
  Files          6       6             
  Lines        921     921             
=======================================
+ Hits         908     910      +2     
+ Misses        13      11      -2     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@jGaboardi jGaboardi merged commit 2a5d6eb into main Nov 24, 2024
11 checks passed
@jGaboardi jGaboardi deleted the GH102_test_with_exclusion_mask branch November 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants