Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Vote-351: Remove Unused Container Element #950

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Dec 6, 2023

Jira ticket

Vote-351

Description

This PR will help resolve an accessibility error flagged on North Dakota/Not Needed. The error was flagging a div that was not being used.

Since registration was not needed for this state the text will not be rendered but the div is still present within the DOM.

For the fix, an if statement was created that if the state was not needed then the div would not be rendered and for anything else, it would be

Deployment and testing

Pre-deploy

n/a

Post-deploy

n/a

QA/Test

  1. visit preview link and inspect and search for class="registered-resources"the expected result is that it will not be present
  2. navigate to another page and search for the same and the expected result is that it will be present
  3. visit several states and ensure there are no visual regression issues
  4. also run the following commands npm run cy:axe and npm run cy:test and ensure tests are passing

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 11, 2023 21:16
@clmedders clmedders requested a review from rayestrada December 11, 2023 21:16
layouts/partials/deadlines.html Outdated Show resolved Hide resolved
@clmedders clmedders requested a review from rayestrada December 12, 2023 18:49
@rayestrada rayestrada merged commit 7323d97 into staging Dec 12, 2023
4 checks passed
@rayestrada rayestrada deleted the bug/vote-351-unused-container branch January 16, 2024 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants