Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2822 add checkbox to enable NVRF link #977

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Sep 11, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2822

Description

Added a new checkbox to enable or display the NVRF link from the state page.
I also cleaned up an issue with the button component.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/admin/content/block/3?destination=/admin/content/block and check the new box in the digital form group.
  2. visit http://vote-gov.lndo.site/register/washington and make sure the text and link are showing
  3. visit http://vote-gov.lndo.site/admin/content/block/3?destination=/admin/content/block and uncheck the new box
  4. visit http://vote-gov.lndo.site/register/washington and make sure the text and link are not showing
  5. try this in another language

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit dfc2fee into dev Sep 18, 2024
2 of 3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2822-nvrf-checkbox branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants