Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2275: Enable and configure stage file proxy #964

Merged
merged 4 commits into from
Sep 6, 2024
Merged

VOTE-2275: Enable and configure stage file proxy #964

merged 4 commits into from
Sep 6, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Sep 6, 2024 •
edited
Loading

Jira ticket

VOTE-2275

Description

Enables and configures stage file proxy module so images are pulled from production site

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. On line 171 of web/sites/settings.local.php change .production to .local so it is like this: $config['config_split.config_split.local']['status'] = TRUE;
  3. run lando drush cim
  4. Navigate to any state page and confirm the missing hero images are now coming through

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal marked this pull request as ready for review September 6, 2024 00:49
@clmedders clmedders merged commit 0d0d9db into dev Sep 6, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2275/stage-file-proxy branch September 6, 2024 14:35
tt-gsa pushed a commit that referenced this pull request Sep 10, 2024
@daniel-crowder @clmedders
@mlloydbixal @rayestrada @SamiraMSadat
Sprint 67 release candidate to STAGE (#966)
65c5418 
* VOTE-2534: Revert upkeep sync file change (#955)

* Vote-2747: update cypress and php version in circleci (#944)

* VOTE-2588: add id to feature card component heading (#958)

* VOTE-2777 add alternate route for Spanish NVRF (#951)

* VOTE-2777 add alternate route for Spanish NVRF

* VOTE-2777 override language switcher for custom route

* phplint fixes

* VOTE-2777 make sure back link recognized language

* VOTE-2777 simplify the form display for the NVRF block

* VOTE-2604: Update drupal core and modules. (#956)

* VOTE-2791 add view revision permissions to content manager and content editor (#959)

* Vote-2655: French Updated Strings (#961)

* VOTE-2275: Enable and configure stage file proxy (#964)

* VOTE-2797 Make the field NVRF PDF pages translatable (#967)

* VOTE-2764: Implement loading animation on NVRF page for slow page load (#963)

* VOTE-2646: Update Arabic Strings (#965)

* VOTE-2802 NVRF updates (#968)

* VOTE-2802 update NVRF to v0.17.0

* VOTE-2802 Remove language selector from nvrf page routes

* VOTE-2802 update path for Spanish NVRF route

* bugfix NVRF svg styling

* Vote-2123: Verify Language options are active (#970)

* Vote-2123: Verify Language optionsq are active

* remove .only flag

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: Mandy Lloyd <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @clmedders