Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2356: NVRF Module #913

Merged
merged 18 commits into from
Aug 9, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Aug 8, 2024

Jira ticket

VOTE-2359

Description

Creates a custom block plugin module with the NVRF React App embedded

Deployment and testing

QA/Testing instructions

  1. Go to Extend and enable NVRF App
  2. Go to block layout, select NVRF Digital Form in the list
  3. Uncheck show title
  4. Navigate Home to test the app
  5. All functionality should be as expected, some styling inheritance issues will be fixed next sprint.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada August 8, 2024 20:24
@rayestrada rayestrada changed the base branch from dev to state-nvrf-integration August 8, 2024 22:19
config/local/config_split.patch.core.extension.yml Outdated Show resolved Hide resolved
web/modules/custom/nvrf_app/nvrf_app.libraries.yml Outdated Show resolved Hide resolved
web/modules/custom/nvrf_app/package.json Outdated Show resolved Hide resolved
web/modules/custom/nvrf_app/package.json Outdated Show resolved Hide resolved
@rayestrada rayestrada marked this pull request as ready for review August 9, 2024 22:39
@rayestrada rayestrada merged commit 28bc21b into state-nvrf-integration Aug 9, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2356/nvrf-module branch August 14, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants