Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-856 update to wysiwyg embedded icon list #582

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Feb 22, 2024

Update content editing permissions

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-856

Description

Add new function to wysiwyg placeholder to embed an icon from a theme file.

Deployment and testing

Post-deploy

  1. run lando retune

QA/Test

  1. visit https://vote-gov.lndo.site/node/add/page
  2. Click on the "embedded content" button in the wysiwyg and select "Placeholder" from the dropdown
  3. Enter "icon:Printer" in the field and submit the dialog
  4. Check and see if the icon shows up in the wysiwyg.
  5. Save the page and check that it displays correct.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Update content editing permissions
@rayestrada rayestrada force-pushed the feature/VOTE-856-icon-list-updates branch from f0c2869 to 5078373 Compare February 22, 2024 18:45
@rayestrada rayestrada requested a review from clmedders February 22, 2024 18:46
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good was able to add icon in the edit view and rendered on page

@rayestrada rayestrada merged commit 0fe5ba7 into dev Feb 23, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-856-icon-list-updates branch February 28, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants