Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-823 VOTE-824 remove publication date module #563

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Feb 16, 2024

Update bixaluswds theme to be managed by composer
Remove unused stable theme

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-823
https://cm-jira.usa.gov/browse/VOTE-824

Description

Remove unused modules and update bixaluswds theme

Deployment and testing

Pre-deploy

BEFORE CHECKING OUT THIS BRANCH!!!

  1. checkout dev branch and import latest db
  2. run lando retune
  3. log into your local
  4. visit these form display settings pages and move "published on" field to "disabled" category
    http://vote-gov.lndo.site/admin/structure/types/manage/page/form-display
    http://vote-gov.lndo.site/admin/structure/types/manage/landing/form-display
    http://vote-gov.lndo.site/admin/structure/types/manage/nvrf_page/form-display
    http://vote-gov.lndo.site/admin/structure/types/manage/state_territory/form-display
    http://vote-gov.lndo.site/admin/structure/types/manage/voter_guide/form-display
  5. visit http://vote-gov.lndo.site/admin/modules/uninstall and uninstall Publication Date module
  6. checkout feature/VOTE-823-pubdate-remove branch

Post-deploy

  1. run lando retune

QA/Test

  1. visit http://vote-gov.lndo.site/node/3/edit and check to make sure there is no publication date field in the sidebar
  2. visit http://vote-gov.lndo.site/about-us and make sure the theme is still loading and there are no console log issues

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@daniel-crowder
Copy link
Contributor

This may be a known issue, but the 'dist' directory is not found within the votegov theme directory. It is located in the vote_gov theme. But aside from this, everything else checks out. Let me know and I can approve if this is acceptable.
Screenshot 2024-02-16 at 10 48 52 AM

@daniel-crowder
Copy link
Contributor

Running npm i and npm run build from the theme directory installed the missing theme files.
Thanks for the instructions!

daniel-crowder
daniel-crowder previously approved these changes Feb 16, 2024
@rayestrada rayestrada force-pushed the feature/VOTE-823-pubdate-remove branch from ef370e9 to 4e6beb6 Compare February 26, 2024 23:50
@rayestrada rayestrada merged commit cc8f9d5 into dev Feb 27, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-823-pubdate-remove branch February 28, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants