Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-657 update s3fs module to 3.4.0 #499

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jan 8, 2024

Update aws-sdk-php dependency to 3.288.1
Update aws-crt-php dependency to v.1.2.3

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-657

Description

Resolving a security vulnerability found from scans.
Updating s3fs module to 3.4.0
Updateing aws-sdk-php dependency to 3.283.10

Deployment and testing

Post-deploy

  1. run lando retune

QA/Test

  1. Test adding new document in the system to make sure it saves to the s3
  2. Test disabling css/js aggregation in the system and reenabling to make sure it works
  3. Test to make sure Tome generation still works and copies the assets

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Update aws-sdk-php dependency to 3.283.10
@rayestrada rayestrada marked this pull request as draft January 8, 2024 18:31
Update aws-crt-php to ^1.2.3
@rayestrada rayestrada marked this pull request as ready for review January 8, 2024 18:59
@rayestrada
Copy link
Contributor Author

This code has been deployed to TEST environment and I've tested uploading new media assets and aggregation.

@daniel-crowder
Copy link
Contributor

Tested on Test and confirmed that file is assessable from static site as well.

@rayestrada rayestrada merged commit 1df7079 into dev Jan 12, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-657-s3fs-aws-sdk-php branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants