Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote 636/state field mail link #492

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Dec 28, 2023

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-636

Description

Added a state mail-in link to the state fields, and to the NVRF API.

Deployment and testing

Pre-deploy

  1. lando retune

QA/Test

  1. View the edit page of a state content page and confirm there is a field for "mail registration link" and "mail registration link override" in the Links tab
  2. Go to the NVRF API confirm the mail registration link and override (hidden) are in the fields list.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit 119b017 into dev Dec 29, 2023
2 of 3 checks passed
Copy link
Contributor

@rayestrada rayestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@rayestrada rayestrada deleted the feature/VOTE-636/state-field-mail-link branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants