Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-587 state selector paragraph refinements #473

Merged
merged 1 commit into from
Dec 18, 2023
Merged

VOTE-587 state selector paragraph refinements #473

merged 1 commit into from
Dec 18, 2023

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Dec 11, 2023 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-587

Description

State selector (Registration tool) paragraph refinements

Deployment and testing

Post-deploy

  1. cd into votegov theme and run npm run build
  2. run lando retune

QA/Test

  1. Edit the homepage http://vote-gov.lndo.site/node/63/edit and add a placeholder value in the registration tool component.
  2. Visit the homepage http://vote-gov.lndo.site/ and check if the placeholder field is displaying correctly in the text field of the component

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested review from mlloydbixal, SamiraMSadat and clmedders and removed request for mlloydbixal and SamiraMSadat December 11, 2023 17:57
clmedders
clmedders approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything working as expected

@rayestrada rayestrada merged commit b22696a into dev Dec 18, 2023
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-587-state-selector-refinement branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders