Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-3138: Adding KO to sidenav fix #1179

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Vote-3138: Adding KO to sidenav fix #1179

merged 1 commit into from
Dec 31, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Dec 23, 2024 •
edited by rayestrada
Loading

Jira ticket

Vote-3138

Description

Adding Korean that was left out by mistake to languages that do not need sidenav

Deployment and testing

Post-deploy steps

1 - lando retune

QA/Testing instructions

  1. visit a voter guide and check that Korean does not have the side nav

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 23, 2024 17:11
@clmedders clmedders requested a review from rayestrada December 23, 2024 17:11
@rayestrada rayestrada merged commit 0a0630c into dev Dec 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @rayestrada