Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-3141 hide NVRF svg icons from screen readers #1160

Merged
merged 1 commit into from
Dec 10, 2024
Merged

VOTE-3141 hide NVRF svg icons from screen readers #1160

merged 1 commit into from
Dec 10, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Dec 9, 2024 •
edited by clmedders
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3141

Description

Hide NVRF svg icons from screen readers

Deployment and testing

Post-deploy steps

  1. lando drush cr

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/register/minnesota/mail-in-form-filler and confirm that the icon list svgs have aria-hidden on them.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from clmedders December 9, 2024 20:12
@clmedders clmedders merged commit ab69eb6 into dev Dec 10, 2024
2 checks passed
@clmedders clmedders deleted the feature/VOTE-3141-aria-svg-icons branch December 10, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders