Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE- 3160 touch points mobile menu #1156

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Dec 9, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3160

Description

Add a button to the touch points form at the bottom of the mobile menu.

Deployment and testing

Post-deploy steps

  1. lando retune
  2. cd into theme, npm run build

QA/Testing instructions

  1. View the site in mobile dimensions and confirm the button matches the design.
  2. Confirm the button displays for multiple screen sizes in mobile and tablet. Note the larger screen sizes place the button start aligned instead of centered.
  3. Switch the Spanish and confirm the button no longer displays in the menu.
  4. Switch to desktop and confirm the modal opens when the floating touch points button is clicked

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module button is showing on desktop
Screenshot 2024-12-13 at 9 47 53 AM

@clmedders
Copy link
Contributor

looks like too the button is smaller then the design not sure if we want to keep it like this or not?

Screenshot 2024-12-13 at 10 03 14 AM

@rayestrada rayestrada dismissed clmedders’s stale review December 18, 2024 23:47

The changes are resolved.

@rayestrada rayestrada merged commit ba91394 into dev Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants