Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-3147: RTL style updates #1144

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Vote-3147: RTL style updates #1144

merged 5 commits into from
Dec 11, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Dec 2, 2024

Jira ticket

Vote-3147

Description

Addressing various RTL style issues:

  1. accessibility page had element off to the side causing it to zoom out in mobile
  2. the arrows for quick links were not pointing the right direction
  3. the accessibility bar was going behind the touchpoints form on the accessibility page
Screen shots
Screenshot 2024-12-01 at 8 45 21 PM

Screenshot 2024-12-01 at 8 44 50 PM

Screenshot 2024-12-01 at 8 44 27 PM

Deployment and testing

Post-deploy steps

  1. cd into the votegov theme and run npm run build

QA/Testing instructions

  1. switch to the AR translation and verify that the arrows for quick links are pointing the right direction
  2. visit the accessibility page and ensure that you do not need to scroll over to see the page while in mobile view
  3. while on the accessibility page scroll to the touchpoints form and check that the accessability bar does not go behind the form.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 2, 2024 01:56
@clmedders clmedders requested a review from rayestrada December 2, 2024 02:55
@clmedders clmedders requested a review from rayestrada December 4, 2024 13:55
@rayestrada
Copy link
Contributor

You were right about using a separate svg for rtl. Changing the pseudo element to inline block caused it to break to a new line by itself when the width of the column decreased.

@rayestrada rayestrada merged commit d70a815 into dev Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants