Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE- 3134 replace online and in-person date fields #1131

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 25, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3134

Description

Replace double fields with default date fields for online and in person.
Delete the double fields from the system.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/node/7/edit
  2. Set the in-person and online deadline fields.
  3. Confirm the specific deadlines display correctly on the page.
  4. Confirm the dates translate when switching languages.
  5. Clear the specific deadlines and confirm the default deadlines display on the page.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders merged commit 6cf4f86 into state-enhancement Nov 27, 2024
2 checks passed
@clmedders clmedders deleted the feature/VOTE-3134/replace-online-inperson-date-fields branch November 27, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants