Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote 3149/state page data analytics #1126

Merged

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 21, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3149

Description

Implement link attributes for google analytics.

  1. Add data-state-ext attribute and values to links defined in the templates
  2. Enable source code editing in the simple wysiwg editor (to allow the attribute to be added to links)

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/admin/content/block/23?destination=/admin/content/block and edit the source code for the NVRF Details field.
  2. Add data-state-ext="nvrf-mail-registration" to the anchor tag
  3. Edit the source code of the military field.
  4. Add data-state-ext="military-registration" to the anchor tag
  5. Go to http://vote-gov.lndo.site/register/alabama and confirm all the data attributes are applied to links as defined in the ticket.
  6. Go to http://vote-gov.lndo.site/node/62/edit
  7. Edit the source code in the override confirm registration field
  8. Add data-state-ext="confirm registration" to the anchor tag
  9. Confirm the Wyoming confirm registration link now has the data attribute.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat marked this pull request as ready for review November 22, 2024 17:13
@rayestrada rayestrada merged commit 0261ecc into state-enhancement Dec 2, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-3149/state-page-data-analytics branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants