Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE 3157 Add render filter to the state mail deadline #1125

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 21, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3157

Description

A render error appeared after updating the latest db (11-21-2024). Last sprints the dates were reverted to be the general deadlines.
I added a missing render filter to the general mail deadline variables.

Deployment and testing

Post-deploy steps

  1. lando db-import drupal_2024-11-21.sql
  2. lando retune

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/register/alabama and confirm the general mail deadline renders correctly for both English and Spanish.
  2. Edit the Alabama data to use a specific date for the mail dealine.
  3. Confirm the specific mail deadline renders correctly.
  4. Visit http://vote-gov.lndo.site/register/american-samoa and confirm that the mail deadline does not display.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders merged commit 0db7827 into state-enhancement Nov 21, 2024
2 checks passed
@clmedders clmedders deleted the bug/VOTE-3157/new-db-render-error branch November 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants