Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE- 3094 Remove merge from override functions #1110

Merged

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 14, 2024

This will ensure an empty override is treated as a value when other values are set.

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3094

Description

Overrides should be handled by block, not per field. When one override field in a block is set, all fields use the override values, even it empty.
To accomplish this, I removed the merge function.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Visit the Alabama page and confirm all the default state content displays.
  2. Edit the Alabama page and set all the override fields.
  3. Confirm the override values display on the page.
  4. Edit the Alabama page and delete one field value per registration type (a mix of headings, content, and link text)
  5. Confirm that for each override field value deleted, no default content displays.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

This will ensure an empty override is treated as a value when other values are set.
@rayestrada rayestrada merged commit 135ce57 into state-enhancement Nov 15, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-3094/default-overrides-remove-merge branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants