Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/vote 3057/remove po strings #1098

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Feature/vote 3057/remove po strings #1098

merged 1 commit into from
Nov 13, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 7, 2024 •
edited by rayestrada
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3057

Description

Remove strings from old state page from the po files.

Deployment and testing

Post-deploy steps

  1. lando retune
  2. If necessary - lando import-translations

QA/Testing instructions

  1. View each translated state page and confirm all the components are translating, especially the dates. Note that the state page content will still be in English.
  2. Spot check the files against the spreadsheet and confirm only state page strings have been removed.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat changed the base branch from dev to state-enhancement November 7, 2024 21:54
@rayestrada rayestrada merged commit 763c695 into state-enhancement Nov 13, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-3057/remove-po-strings branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada Awaiting requested review from rayestrada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamiraMSadat @rayestrada