Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2902: Add state specific nvrf api data endpoint. #1020

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented Oct 1, 2024

Jira ticket

VOTE-2902

Description

Update NVRF API view to include a dynamic state specific data view.

Deployment and testing

Post-deploy steps

  1. Locally, run lando retune to install updates.

QA/Testing instructions

  1. Goto /nvrf/assets/states/{state_abbreviation}/data.json
  2. Replace {state_abbreviation} with a state (ie. nj) and confirm that the correct json data is loaded.
  3. Test the same url with translation /{langcode}/nvrf/assets/states/{state_abbreviation}/data.json
  4. Repeat step 2

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit d363808 into dev Oct 1, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2902-state-api-endpoints branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants