Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2585 add data fields for string translations #1017

Merged
merged 1 commit into from
Oct 1, 2024
Merged

VOTE-2585 add data fields for string translations #1017

merged 1 commit into from
Oct 1, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Sep 30, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2585

Description

Add new data fields for string translations

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. check to make sure new fields were added to the data model based on the documentation linked in the ticket.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@daniel-crowder daniel-crowder self-assigned this Oct 1, 2024
@daniel-crowder daniel-crowder merged commit dbd4606 into dev Oct 1, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2585-string-data-model branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-crowder daniel-crowder daniel-crowder approved these changes

Assignees

@daniel-crowder daniel-crowder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @daniel-crowder