Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2090 Font Size Consolidation #2202

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

cwacht
Copy link
Contributor

@cwacht cwacht commented Jan 29, 2025

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2090

Description

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Review font sizes of all the various types of text across all pages. Ensure that all font sizes appear to be correct.

This resource contains a list of all the types of text that were changed (but it has not been updated with some of the recently adjusted sizes)
https://www.notion.so/cwacht/Font-Size-Consolidation-1436f4c372d9805b9904ddbf2b97a3bd

Also this Figma has a similar list of the various types of text and what pages to find them on:
https://www.figma.com/design/0mHLrOK4W95oiKXGUzwohW/USAGov--Font-size-analysis?node-id=66-1402&node-type=frame&t=vmcBW6mqGlpez73Y-0

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Test instruction 1
  • Test instruction 2
  • Test instruction 3

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

… week of feedback

Decrease heading sizes by 1 token
Temporary button font size styling until content review
Benefits Search Page adjustments
Phone number size increase to 'md' on desktop
Directory Letter heading and pagination decrease to 'xl'
- **Homepage** - "How do I", decrease style to 'lg, 23.36px'
- **Footer** - "USAGov Contact Center" and "Find us" need to match the "Sign up to receive" size
- **Footer**- The top column alignment for Federal agencies is still off, but we believe it will be resolved when the updates are pushed to production.
- **Benefit Finder LP** - decrease H2s (Benefit finder tool and Find benefits by category) to 'md'
…figs

because we're not ready to edit all the button content and the config change seems to automatically strip classes...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant