Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1826-jquery-consoldiation: change $ to jQuery in reportAP… #2199

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jacobaaronyeager
Copy link
Collaborator

…roblem.js and removed jquery cdn call in site issue report twig in en and esp

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1826

Description

Removed call to CDN jQuery from field--node--field-custom-twig-content-site-issue-report-form.html.twig and field--node--field-custom-twig-content-reporte-problemas-en-este-sitio-web.html.twig and replaced $ with jQuery in reportAProblem.js.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Go to /site-issue-report-form and/or /es/reporte-problemas-en-este-sitio-web and attempt to submit the form without filling it out. It should stop you. Also need to figure out how to test the recaptcha.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

…roblem.js and removed jquery cdn call in site issue report twig in en and esp
@jacobaaronyeager jacobaaronyeager requested a review from akf January 28, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants