Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usagov 2193 update ceo text #2172

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Usagov 2193 update ceo text #2172

merged 2 commits into from
Jan 16, 2025

Conversation

developer43
Copy link
Contributor

@developer43 developer43 commented Jan 15, 2025

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2193

Description

Update text to contact the president

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

NOTE: Shoshana has just disabled custom twig content for these pages on prod, so if you get a database snapshot created 1/14, you will need to re-enable it for that page (look for the "Custom twig content" checkbox). 

Screenshot 2025-01-15 at 8 57 28 AM Screenshot 2025-01-15 at 8 57 16 AM

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@whitealbum whitealbum self-assigned this Jan 16, 2025
@whitealbum whitealbum merged commit b0302ae into dev Jan 16, 2025
4 of 5 checks passed
@whitealbum whitealbum deleted the usagov-2193-update-ceo-text branch January 16, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants